-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Refactor: Remove Pandas as a dependency by using the natively in built csv module instead #1131
Code Refactor: Remove Pandas as a dependency by using the natively in built csv module instead #1131
Conversation
5a825d5
to
b4d649e
Compare
Fixed all inconsistencies, tracking functionality now works as it did before removing pandas dependency |
@dzumii could you also share before and after results? That is, results from the master branch and your work? |
@DhanshreeA @dzumii anything you need from me here? |
All good on my end. |
@DhanshreeA, I have been able to finally fix the inconsistency in the here is the comparison between the two metric files when i run I also noticed a warning when i try to close a model having used the track flags |
c744232
to
3973044
Compare
Hey @dzumii Could you please report this in an issue (the warning) and we can tackle it there? |
LGTM on the PR! Ready to merge. |
Ok, will do that |
Description
Code refactoring to remove Pandas from the tracking functionality and implement the functionality using built-in Python libraries.
Changes Made
read_csv
function to read CSV files using the native CSV library.stats
function to calculate statistics using the statistics library.get_file_size
functionStatus
To Do
check_types
function.get_file_size
function.This is still a Work In Progress
Comments and suggestions would be really appreciated
Related to #1090
Closes #1054