ci: move black & isort to pre-commit #1596
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijis
force-pushed
the
pre-commit-config
branch
from
9d72915
to
78b4a33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit is great tool to run these kind of auto-formatters in isolated environments. There are more hooks which are supported, but I haven't introduced any new ones for now. I just moved 2 packages that were already used here, and use the GitHub action to run them on CI.
The step further is to use pre-commit.ci which has a couple of extra features:
However, this requires a maintainer to sign-up, and I appreciate that it's yet another service.