Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated summary columns. #376

Merged
merged 2 commits into from
Oct 13, 2021

Conversation

berland
Copy link
Collaborator

@berland berland commented Oct 12, 2021

This is not a problem pr. now for CSV output, but will
be a later problem when dataframes are written to arrow format.

@berland berland linked an issue Oct 12, 2021 that may be closed by this pull request
This is not a problem pr. now for CSV output, but will
be a later problem when dataframes are written to arrow format.
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🚀

logger.warning(
"Duplicated columns detected, check your DATA file "
"for repeated vectors in the SUMMARY section"
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏

ecl2df/summary.py Outdated Show resolved Hide resolved
Co-authored-by: Anders Fredrik Kiær <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2021

Codecov Report

Merging #376 (52fcfb7) into master (90281ca) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #376   +/-   ##
=======================================
  Coverage   97.57%   97.58%           
=======================================
  Files          23       23           
  Lines        3181     3186    +5     
=======================================
+ Hits         3104     3109    +5     
  Misses         77       77           
Impacted Files Coverage Δ
ecl2df/summary.py 97.70% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90281ca...52fcfb7. Read the comment docs.

@berland berland merged commit 35a379c into equinor:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[summary] Check double named vectors
3 participants