Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checkbox for important tasks in default configuration #574

Merged
merged 8 commits into from
May 31, 2024

Conversation

david-0609
Copy link
Contributor

Screenshot_20240507_192116
Many people use Obsidian to organise their tasks using checkboxes and I added a checkbox to the default configuration that indicates that the task is important. I also added a highlight group ("ObsidianImportant") that uses a darker red colour. Also I shifted the order for toggle checkboxes to make this checkbox make sense in terms of order.

Copy link
Owner

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks @david-0609. I actually already have something similar in my personal config. Can you just update the config example in the README? Then we'll get this merged.

@david-0609
Copy link
Contributor Author

This looks good, thanks @david-0609. I actually already have something similar in my personal config. Can you just update the config example in the README? Then we'll get this merged.

I updated the example config in the README, you can merge now

@@ -463,6 +463,7 @@ This is a complete list of all of the options that can be passed to `require("ob
["x"] = { char = "", hl_group = "ObsidianDone" },
[">"] = { char = "", hl_group = "ObsidianRightArrow" },
["~"] = { char = "󰰱", hl_group = "ObsidianTilde" },
["!"] = { char = "", hl_group = "ObsidianImportant" },
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This HL group also needs to be defined below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HL Group has been updated in readme

Copy link
Owner

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @david-0609!

@epwalsh epwalsh merged commit 0c819b5 into epwalsh:main May 31, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants