Forex monkey patch #236
Closed
Forex monkey patch #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@macanudo527, is this ready for review? I see there is a small static analysis failure and wanted to check with you before starting to review. Thanks! |
|
This is just a temporary monkey patch to get it to work, so please just ignore it. I'll delete it as soon as I get a proper PR together. I just need to fine tune the new forex plugin and clean it up so it is compatible with your PR. Its going to be a pretty big PR, but I'll try to break out the commits so it is easy to see/review. |
|
#225 Will replace this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #234
It skips pricing from the web of native fiat transactions that might be inputted with some plugins. It assigns a spot price of 1.
This adds CSV pricing for forex which will later be refactored.