Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native ESM + update dependencies #118

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Conversation

onemen
Copy link
Contributor

@onemen onemen commented Jun 11, 2023

@kentcdodds

Some tests are not ready, but they where not ready before this PR.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just two things.

package.json Outdated
Comment on lines 58 to 61
"workspaces": [
"exercises/*/*",
"examples/*"
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this in this project because those directories don't have package.json files in them.

scripts/diff.js Show resolved Hide resolved
@onemen
Copy link
Contributor Author

onemen commented Jun 13, 2023

its ready

@onemen onemen requested a review from kentcdodds June 13, 2023 13:22
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit fba1995 into epicweb-dev:next2 Jun 13, 2023
3 checks passed
@onemen onemen deleted the pr/esm branch June 13, 2023 18:25
kentcdodds pushed a commit that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants