Skip to content

Commit

Permalink
fix review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
onemen committed Jun 13, 2023
1 parent e0648c5 commit 171c767
Show file tree
Hide file tree
Showing 5 changed files with 41 additions and 76 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { expect, testStep } from '@kentcdodds/workshop-app/test'
import { render, screen } from '@testing-library/react'
import { userEvent } from '~/shared/user-event.cjs'
import { App } from './app.jsx'
import { App } from './app.tsx'

await testStep('can render the app', () => {
render(<App />)
Expand Down
62 changes: 29 additions & 33 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 9 additions & 10 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"npm": ">=8.16.0"
},
"dependencies": {
"@kentcdodds/workshop-app": "^1.39.2",
"@kentcdodds/workshop-app": "^1.39.3",
"react": "^18.2.0",
"react-dom": "^18.2.0"
},
Expand All @@ -25,14 +25,14 @@
"@testing-library/dom": "^9.3.0",
"@testing-library/react": "^14.0.0",
"@testing-library/user-event": "^14.4.3",
"@types/node": "^20.2.6",
"@types/react": "^18.2.11",
"@types/react-dom": "^18.2.4",
"@types/node": "^20.3.0",
"@types/react": "^18.2.12",
"@types/react-dom": "^18.2.5",
"cross-env": "^7.0.3",
"dotenv": "^16.1.4",
"eslint": "^8.42.0",
"eslint-config-prettier": "^8.8.0",
"eslint-config-react-app": "^7.0.1",
"glob": "^10.2.7",
"npm-run-all": "^4.1.5",
"prettier": "^2.8.8",
"typescript": "^5.1.3"
Expand All @@ -50,15 +50,14 @@
"validate": "npm-run-all --parallel --print-label --print-name --continue-on-error test lint typecheck"
},
"eslintConfig": {
"extends": "react-app",
"extends": [
"react-app",
"prettier"
],
"rules": {
"@typescript-eslint/no-unused-expressions": "off"
}
},
"workspaces": [
"exercises/*/*",
"examples/*"
],
"repository": {
"type": "git",
"url": "git+https://github.com/kentcdodds/advanced-react-patterns.git"
Expand Down
2 changes: 2 additions & 0 deletions playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ const config: PlaywrightTestConfig = {
command: `cross-env PORT=${PORT} npm run start`,
port: Number(PORT),
reuseExistingServer: true,
stdout: 'pipe',
stderr: 'pipe',
},
}

Expand Down
32 changes: 0 additions & 32 deletions scripts/diff.js

This file was deleted.

0 comments on commit 171c767

Please sign in to comment.