Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataSources]: improved sorting. #2238

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

Kuznietsov
Copy link
Collaborator

@Kuznietsov Kuznietsov commented May 13, 2024

Summary

Implements idea №4 from #2192.

Improved sorting by adding sortingSettings to DataSources.

@Kuznietsov Kuznietsov self-assigned this May 13, 2024
@Kuznietsov Kuznietsov removed the request for review from dimaanj May 13, 2024 14:11
Copy link

github-actions bot commented May 13, 2024

Generated by: track-bundle-size
Generated at: Thu, 16 May 2024 10:10:47 GMT
Bundle size diff (in kBytes). Not gzipped. Both CSS & JS included.
Baseline: v5.7.1 (2024-04-18)
CI Status: ok

Module Baseline Size
(v5.7.1)
Size Diff Within
Threshold
Threshold
(min - max)
templateApp 743.1 745.82 +2.7
js:+0.36
css:+2.34
🆗 668.8 - 817.42
@epam/app 6371.95 6638.37 +266.41
js:+199.67
css:+66.75
🆗 5734.76 - 7009.15
@epam/draft-rte 53.78 53.77 -0.01
js:0
css:0
🆗 48.4 - 59.16
@epam/electric 4.54 4.52 -0.01
js:0
css:-0.01
🆗 4.08 - 4.99
@epam/promo 55.42 56.96 +1.53
js:0
css:+1.54
🆗 49.88 - 60.97
@epam/uui-extra 0.21 0.21 0
js:0
css:0
🆗 0.19 - 0.23
@epam/loveship 101.48 102.2 +0.73
js:0
css:+0.73
🆗 91.33 - 111.63
@epam/uui-components 256.52 257.65 +1.13
js:+1.11
css:+0.02
🆗 230.87 - 282.17
@epam/uui-core 325.74 330.47 +4.73
js:+4.73
css:0
🆗 293.17 - 358.32
@epam/uui-db 44.7 44.7 0
js:0
css:0
🆗 40.23 - 49.17
@epam/uui-docs 200.05 204.51 +4.45
js:+4.28
css:+0.17
🆗 180.05 - 220.06
@epam/uui-editor 173.13 167.06 -6.07
js:-6.08
css:+0.01
🆗 155.82 - 190.45
@epam/uui-timeline 47.17 47.17 +0
js:+0
css:+0
🆗 42.45 - 51.88
@epam/uui 590.49 593.78 +3.29
js:+1.41
css:+1.88
🆗 531.44 - 649.54
new sizes (raw)

To set the sizes as a new baseline, you can copy/paste next content to the uui-build/config/bundleSizeBaseLine.json and commit the file.

{
  "version": "5.7.2",
  "timestamp": "2024-05-16",
  "sizes": {
    "templateApp": {
      "css": 282989,
      "js": 480722
    },
    "@epam/app": {
      "css": 1656173,
      "js": 5141516
    },
    "@epam/draft-rte": {
      "css": 9761,
      "js": 45303
    },
    "@epam/electric": {
      "css": 2275,
      "js": 2358
    },
    "@epam/promo": {
      "css": 41940,
      "js": 16381
    },
    "@epam/uui-extra": {
      "css": 0,
      "js": 213
    },
    "@epam/loveship": {
      "css": 50198,
      "js": 54461
    },
    "@epam/uui-components": {
      "css": 22235,
      "js": 241598
    },
    "@epam/uui-core": {
      "css": 0,
      "js": 338403
    },
    "@epam/uui-db": {
      "css": 0,
      "js": 45769
    },
    "@epam/uui-docs": {
      "css": 3366,
      "js": 206048
    },
    "@epam/uui-editor": {
      "css": 12631,
      "js": 158440
    },
    "@epam/uui-timeline": {
      "css": 2253,
      "js": 46048
    },
    "@epam/uui": {
      "css": 270287,
      "js": 337749
    }
  }
}

Generated by: generate-components-api
CI Status: error

Total amount of exported types/props without JSDoc comments

Amount
Types 270 (+4) ⚠️🆗
Props 245 (+6) ⛔
New missing comments
NOTE: It's either a new exported types/props without JSDoc, or it's an existing code from which you deleted the JSDoc comments.
Types:
- @epam/uui-core:FieldSortingSettings
- @epam/uui-core:GetFieldSortingSettings
- @epam/uui-core:SortingSettings
- @epam/uui-core:SortingSettingsModifier
Props:
- @epam/uui-core:FieldSortingSettings/comparator
- @epam/uui-core:FieldSortingSettings/direction
- @epam/uui-core:FieldSortingSettings/sortBy
- @epam/uui-core:SortConfig/sortingSettings
- @epam/uui-core:SortingSettings/[SortingSettingsModifiers.ALWAYS]
- @epam/uui-core:SortingSettings/[key: string]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant