Update docker-compose-browserless.yaml #533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JOduMonT
commented
May 9, 2024
JOduMonT
commented
- docker made the parameter version is obsolete
- since they are in the same docker-compose it is unnecessary to expose browserless port to access it from big-agi.
- add restart for more conveniency (start when server reboot)
- docker made the parameter version is obsolete - since they are in the same docker-compose it is unnecessary to expose browserless port to access it from big-agi. - add restart for more conveniency (start when server reboot)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
enricoros
requested changes
May 10, 2024
| image: browserless/chrome:latest | ||
| ports: | ||
| - "9222:3000" # Map host's port 9222 to container's port 3000 |
There was a problem hiding this comment.
Is this needed? I see it's removed, but it could be important?
There was a problem hiding this comment.
Note: this does not seem to be needed anymore indeed. do you know if it's safe to remove it for everyone?
| services: | ||
| big-agi: | ||
| container_name: big-agi |
There was a problem hiding this comment.
I have a lint error here, because the indent is the same as the big-agi: and should be more?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.