Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to property access instead constants #69

Merged
merged 7 commits into from
Oct 17, 2023

Conversation

enisn
Copy link
Owner

@enisn enisn commented Oct 7, 2023

Resolves #68


Changes

  • All the Expression.Constant() usages are converted to Expression.Property() (when possible)

Braking Changes

  • BuildExpression() methods have single parameter and it's ExpressionBuildContext from now.

@enisn enisn added this to the V3.0 - Much more Dynamics milestone Oct 7, 2023
@enisn enisn linked an issue Oct 7, 2023 that may be closed by this pull request
@enisn
Copy link
Owner Author

enisn commented Oct 7, 2023

I broke some of cases with this changes, I'll work on them

@enisn enisn marked this pull request as ready for review October 17, 2023 16:06
@enisn enisn merged commit 08fe3bb into develop Oct 17, 2023
3 checks passed
@enisn enisn deleted the property-access-instead-constant branch October 17, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: constants instead of parameters
1 participant