Update adds support for diffing element defenitions with slots #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update moves `npm ci` to `npm i` so as not to require a `package-lock.json`
macdonst
requested changes
Jun 3, 2024
| updated.innerHTML = tmp.trim() | ||
| updated.innerHTML = tmp | ||
|
|
||
| if (this['scrubTemplate']) { |
There was a problem hiding this comment.
Curious as why you wrote it this way instead of:
if (typeof this. scrubTemplate === 'function') {| @@ -25,15 +25,16 @@ | |||
| }, | |||
| "homepage": "https://github.com/enhance-dev/enhance-morphdom-mixin#readme", | |||
| "devDependencies": { | |||
| "@enhance/custom-element": "^1.2.3", | |||
| "@enhance/custom-element": "^1.2.3-next.0", | |||
There was a problem hiding this comment.
This seems to be pointing to an older release. I had to do a:
npm install "https://github.com/enhance-dev/enhance-custom-element.git#dom-diffing-slots" --saveand then I could get the tests to pass.
There was a problem hiding this comment.
I had reverted to v1.2.3 in order to use the latest version of custom element when it was released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP Requires the next version of Custom Element Mixin