Add tests to test_datastructure
#2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
requested changes
Feb 12, 2024
tests/test_datastructures.py
Outdated
| @@ -58,6 +58,9 @@ def test_url() -> None: | |||
| url = URL("http://u:p@host:80") | |||
| assert url.replace(port=88) == URL("http://u:p@host:88") | |||
|
|
|||
| url = URL("http://host:80") | |||
| assert url.replace(username="user").password is None | |||
There was a problem hiding this comment.
What are you testing here?
Comment on lines
+76
to
+79
| u = u.include_query_params(page=4, search="testing") | ||
| assert str(u) == "https://example.org/path/?page=4&search=testing" | ||
| u = u.remove_query_params(["page", "search"]) | ||
| assert str(u) == "https://example.org/path/" |
There was a problem hiding this comment.
What are you testing here?
Better to post the lines you are testing, otherwise, this will take some time for me.
Kludex
reviewed
Feb 29, 2024
tests/test_datastructures.py
Outdated
Comment on lines
148
to
160
| scope_with_host_header = { | ||
| "scheme": "http", | ||
| "path": "/some/path", | ||
| "query_string": b"query=string", | ||
| "headers": [ | ||
| (b"content-type", b"text/html"), | ||
| (b"host", b"example.com:8000"), | ||
| (b"accept", b"text/html"), | ||
| ], | ||
| } | ||
| url_from_scope_with_host = URL(scope=scope_with_host_header) | ||
| assert url_from_scope_with_host.hostname == "example.com" | ||
|
|
There was a problem hiding this comment.
I meant doing it here...
starlette/starlette/datastructures.py
Lines 39 to 40 in 74ccb96
Kludex
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add test cases to
test_datastructures.pyin order to have 100 coverage. Related to this issue and this PR.Checklist