-
-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove databases package from config docs #2092
Merged
Kludex
merged 17 commits into
encode:master
from
aminalaee:remove-databases-from-config-docs
Dec 16, 2023
Merged
Remove databases package from config docs #2092
Kludex
merged 17 commits into
encode:master
from
aminalaee:remove-databases-from-config-docs
Dec 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
reviewed
Mar 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I look for databases
in the docs, I can still find others 🤔
@Kludex You mean in the |
Kludex
reviewed
Mar 24, 2023
Kludex
approved these changes
Mar 24, 2023
Kludex
requested changes
Mar 27, 2023
Kludex
reviewed
Apr 7, 2023
Kludex
reviewed
Apr 10, 2023
…aee/starlette into remove-databases-from-config-docs
Kludex
requested changes
May 31, 2023
Kludex
reviewed
Jun 1, 2023
Kludex
requested changes
Jun 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added last bit
Co-authored-by: Marcelo Trylesinski <[email protected]>
Kludex
reviewed
Jun 2, 2023
Merged
…atabases-from-config-docs
…bases-from-config-docs
Kludex
reviewed
Jun 5, 2023
BilalAlpaslan
approved these changes
Jun 5, 2023
Kludex
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subset of #1921