Fix encode host (#2886)

* Fix requiring dot literal rather than any character in IPv4 * Add check to prevent future errors
encode · Oct 10, 2023 · e63b659 · e63b659
1 parent 3ba5fe0
commit e63b659
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/httpx/_urlparse.py b/httpx/_urlparse.py
@@ -87,7 +87,7 @@
 
 # We use these simple regexs as a first pass before handing off to
 # the stdlib 'ipaddress' module for IP address validation.
-IPv4_STYLE_HOSTNAME = re.compile(r"^[0-9]+.[0-9]+.[0-9]+.[0-9]+$")
+IPv4_STYLE_HOSTNAME = re.compile(r"^[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+$")
 IPv6_STYLE_HOSTNAME = re.compile(r"^\[.*\]$")
 
 

diff --git a/tests/test_urlparse.py b/tests/test_urlparse.py
@@ -45,6 +45,12 @@ def test_urlparse_normalized_host():
  assert url.host == "example.com"
 
 
+def test_urlparse_ipv4_like_host():
+ """rare host names used to quality as IPv4"""
+ url = httpx.URL("https://023b76x43144/")
+ assert url.host == "023b76x43144"
+
+
 def test_urlparse_valid_ipv4():
  url = httpx.URL("https://1.2.3.4/")
  assert url.host == "1.2.3.4"