Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove long deprecated code from request wrapper #9441

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

sevdog
Copy link
Contributor

@sevdog sevdog commented Jun 17, 2024

Description

This code has been deprecated and "removed" from version 3.2 (which was released in 2015).

It is not worth keeping it since all the docs states to use the lowercase variant.

@auvipy auvipy requested a review from a team June 18, 2024 16:46
@auvipy
Copy link
Member

auvipy commented Jun 18, 2024

I think we might be good to go with this. but I still want to move cautiously so requested another round from other team members

Copy link
Contributor

@peterthomassen peterthomassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@auvipy auvipy merged commit e13688f into encode:master Jun 18, 2024
7 checks passed
@sevdog sevdog deleted the remove-long-deprecations branch June 19, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants