Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate packaging to pyproject.toml #9056

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

deronnax
Copy link
Contributor

@deronnax deronnax commented Jul 27, 2023

Just an initiative of my own.

@deronnax deronnax marked this pull request as draft July 27, 2023 13:40
@deronnax deronnax force-pushed the migrate_setuppy_to_pryoject.toml branch from 6344069 to 42d468b Compare July 27, 2023 13:41
@deronnax
Copy link
Contributor Author

deronnax commented Jul 29, 2023

OK, it's almost ready except:

  • It can't work on python 3.6 because having setuptools being able to read metadata from pyproject.toml requires setuptools > 61.2, which does not support python 3.6 anymore.
  • I need to figure out what is conftest.py doing with the package_root

@deronnax deronnax force-pushed the migrate_setuppy_to_pryoject.toml branch from 8c65e6d to 6e67258 Compare July 29, 2023 17:07
@terencehonles
Copy link
Contributor

  • I need to figure out what is conftest.py doing with the package_root

This is unrelated to your PR and I fixed it with #9129

@deronnax deronnax force-pushed the migrate_setuppy_to_pryoject.toml branch from 6e67258 to b16826c Compare October 5, 2023 16:28
@deronnax deronnax marked this pull request as ready for review October 5, 2023 22:48
@deronnax
Copy link
Contributor Author

deronnax commented Oct 5, 2023

Wow. It works indeed. Thank you so much.

@auvipy auvipy self-requested a review October 6, 2023 05:42
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to hold this off for now. As we got other priorities.

@deronnax
Copy link
Contributor Author

deronnax commented Oct 6, 2023

Sure. A vague estimation of when it would become envisageable ?

@deronnax deronnax changed the title migrate setup.cfg to pyproject.toml migrate packaging to pyproject.toml Oct 7, 2023
@deronnax
Copy link
Contributor Author

deronnax commented Feb 5, 2024

To merge after #9210, I hope.

pyproject.toml Outdated Show resolved Hide resolved
@deronnax deronnax force-pushed the migrate_setuppy_to_pryoject.toml branch from 12a5a0b to cf25dcd Compare February 27, 2024 13:37
@deronnax
Copy link
Contributor Author

watch-out: this PR is intended to be squash-merged

@tomchristie
Copy link
Member

So... this is a good example of a nice little pr that's a bit stalled. I don't really have any extra bandwidth to keep this moving, given existing commitments. Should we be having a discussion about getting the project into jazzband.co so that we've got a lower barrier of entry for new maintainers?

@deronnax
Copy link
Contributor Author

Hey, that's a very interesting decision that is (way) beyond the scope of my humble little PR. Maybe let's open a dedicated issue ou GitHub discussion?

"Operating System :: OS Independent",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.6",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in the current state, indeed

This reverts commit c2062da.
@deronnax
Copy link
Contributor Author

deronnax commented Feb 28, 2024

So, for remember, python 3.6 support is removed in this PR because of setuptools > 61.2 which is required for pyproject.toml support, does not support python 3.6.
I also did #9133, in which python support is discussed, and we figured that according to our policy, we still need to support python 3.6 and 3.7 because the last django we currently support, the 3.2, still supports them. So this MR can't be merged until we drop support of django 3.2 (which would be when django 5.2 is released, mid-2024).

Technically I could do a version of this PR were DRF could not be built on python 3.6 anymore, but still be installed on it, but that would be I think a lot of CI work, and it's simpler to just wait 3 months.

To hold until Django 5.2 is released, then.

@deronnax deronnax marked this pull request as draft February 28, 2024 09:02
@auvipy
Copy link
Member

auvipy commented Feb 28, 2024

So... this is a good example of a nice little pr that's a bit stalled. I don't really have any extra bandwidth to keep this moving, given existing commitments. Should we be having a discussion about getting the project into jazzband.co so that we've got a lower barrier of entry for new maintainers?

No.

@deronnax
Copy link
Contributor Author

@auvipy what do you propose then? DRF has been zombie for at least 2 years. PRs are not reviewed, questions are not answered.

@deronnax deronnax marked this pull request as ready for review March 14, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants