Get data with query params #8951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
requested changes
Apr 18, 2023
| @@ -39,6 +39,13 @@ class ListModelMixin: | |||
| def list(self, request, *args, **kwargs): | |||
| queryset = self.filter_queryset(self.get_queryset()) | |||
|
|
|||
| try: | |||
| params = {key: value for key, value in request.query_params.items() if key in self.model._meta.get_fields()} | |||
There was a problem hiding this comment.
would you mind adding unit test to verify this change?
|
Thanks for you're interest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ability to filter the queryset based on query parameters included in the request URL. The
listmethod now checks if the query parameters correspond to valid fields in the model, and filters the queryset accordingly. This improves the flexibility of the view and allows clients to retrieve a more specific subset of data.