Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove regal port #21893

Closed
wants to merge 1 commit into from
Closed

Remove regal port #21893

wants to merge 1 commit into from

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented May 6, 2024

The regal project seems like its been dead for many years and the repo from which it was forked doesn't seem to exist anymore: https://github.com/p3/regal

I'm not sure we want to continue supporting it as first class thing if there is nobody upstream to report issues to. If it turns out that there are folks who really depend on this we can consider moving it into tools/ports/conrib.

See #21885

The regal project seems like its been dead for many years and the repo
from which it was forked doesn't seem to exist anymore:
https://github.com/p3/regal

I'm not sure we want to continue supporting it as first class thing if
there is nobody upstream to report issues to.  If it turns out that
there are folks who really depend on this we can consider moving it into
`tools/ports/conrib`.

See emscripten-core#21885
@sbc100 sbc100 requested review from kripken and dschuff May 6, 2024 02:03
@sbc100
Copy link
Collaborator Author

sbc100 commented May 6, 2024

One other motivation for removing this is that it is one of the slower ports to build, coming it at 8x slower than musl/libc (16 seconds vs 2 seconds on my machine with 128 cores), so it adds to our build/test overheads.

@dschuff
Copy link
Member

dschuff commented May 6, 2024

I think this makes sense to me, interested to get @kripken's opinion too

@kripken
Copy link
Member

kripken commented May 6, 2024

I'd lean against removing this entirely, since it does give us some more GL ES coverage, indirectly (in the GL ES it ends up emulating desktop GL using). But maybe that's not a strong reason. If no one responds on the mailing list I'd be ok removing it.

@Hex4dec
Copy link

Hex4dec commented May 19, 2024

I'm depending on Regal, since unfortunately OpenJDK does not have GL ES support. gl4es would only solve half of the issue, since many Java libraries also dynamically link to GL.

@sbc100
Copy link
Collaborator Author

sbc100 commented May 20, 2024

Closing for now. @kripken pointed out that the regal build actually provides a quite a bit of test coverage for our GLES implementation.

@sbc100 sbc100 closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants