[jspi] Switch to new JSPI API. #21815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should wait for chrome unstable to include the new API (v126.0.6430) before we land this. |
brendandahl
force-pushed
the
jspi-new-api
branch
from
4afb5ba
to
ab899d4
Compare
sbc100
approved these changes
Apr 24, 2024
|
This would make asyncify useless, right? |
Potentially, it will probably be awhile before JSPI is supported everywhere though. There's also a few areas where binaryen's asyncify is slightly different and may be preferred. |
|
This PR also depends on WebAssembly/binaryen#6546 |
|
It seems that we have to solve #21081 before completely going over. |
brendandahl
force-pushed
the
jspi-new-api
branch
2 times, most recently
from
7855916
to
e6e8ac0
Compare
brendandahl
force-pushed
the
jspi-new-api
branch
2 times, most recently
from
f5e8b95
to
f6e43a8
Compare
Differences with the new API: - The JS engine now takes care of the suspender, so we don't need to modify the wasm file with binaryen. - Imports and exports and are now marked as async with WebAssembly.Suspending and WebAssembly.promising wrappers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differences with the new API: