Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change mqtt.retry_interval default value to infinity #13080

Merged
merged 2 commits into from
May 31, 2024

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented May 21, 2024

Fixes EMQX-12281
See also: #12945

Release version: v/e5.8.0

Previous Setting: The default value for retry_interval was 30 seconds.

New Default: The default retry_interval has been changed to 'infinity'. With this update, EMQX will not automatically retry message deliveries by default.

Compliance and Compatibility: Aligning with MQTT specification standards, in-session message delivery retries are not typically compliant. We recognize that some users depend on this feature, so the option to configure retries remains available for backward compatibility.

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zmstone zmstone force-pushed the 0521-default-retry_interval-to-infinity branch from a6fcf57 to 7cd644e Compare May 21, 2024 07:59
@zmstone zmstone changed the title breaking: change message retry_interval default value to infinity breaking: change mqtt.retry_interval default value to infinity May 21, 2024
@zmstone zmstone force-pushed the 0521-default-retry_interval-to-infinity branch from 7cd644e to 37cdd19 Compare May 21, 2024 08:02
ieQu1
ieQu1 previously approved these changes May 21, 2024
@zmstone zmstone force-pushed the 0521-default-retry_interval-to-infinity branch from c56c2af to 3fb8c57 Compare May 21, 2024 19:54
@zmstone zmstone force-pushed the 0521-default-retry_interval-to-infinity branch from 3fb8c57 to 1801a36 Compare May 31, 2024 06:38
@zmstone zmstone marked this pull request as ready for review May 31, 2024 06:38
@zmstone zmstone requested review from lafirest and a team as code owners May 31, 2024 06:38
@zmstone zmstone changed the title breaking: change mqtt.retry_interval default value to infinity change mqtt.retry_interval default value to infinity May 31, 2024
Previous Setting: The default value for `retry_interval` was 30 seconds.

New Default: The default `retry_interval` has been changed to 'infinity'.
With this update, EMQX will not automatically retry message deliveries
by default.

Compliance and Compatibility: Aligning with MQTT specification
standards, in-session message delivery retries are not typically
compliant. We recognize that some users depend on this feature, so the
option to configure retries remains available for backward
compatibility.
@zmstone zmstone force-pushed the 0521-default-retry_interval-to-infinity branch from 1801a36 to fb07f40 Compare May 31, 2024 15:53
@zmstone zmstone merged commit 12fd1f6 into emqx:master May 31, 2024
177 checks passed
@zmstone zmstone deleted the 0521-default-retry_interval-to-infinity branch May 31, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants