chore: upgrade kafka producer lib wolff to 1.10.4 handle message_too_large
#13079
+13
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
force-pushed
the
0521-handle-kafka-message_too_large-error
branch
2 times, most recently
from
fb45649
to
d595a9f
Compare
zmstone
changed the title
message_too_large
thalesmg
previously approved these changes
May 21, 2024
zmstone
force-pushed
the
0521-handle-kafka-message_too_large-error
branch
from
d595a9f
to
fc914e5
Compare
wolff-1.10.4 handles message_too_large error code from Kafka. It tries to split the too-large batch into single-call batches (for EMQX, one call batch is always one message), and retry. In case a single-call batch is too large, EMQX should increment a failure counter.
zmstone
force-pushed
the
0521-handle-kafka-message_too_large-error
branch
from
fc914e5
to
a00d9f1
Compare
ieQu1
approved these changes
May 30, 2024
qzhuyan
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-12382
Release version: v/e5.7.1
Summary
wolff-1.10.4 handles message_too_large error code from Kafka. It tries to split the too-large batch into single-call batches (for EMQX, one call batch is always one message), and retry. In case a single-call batch is too large, EMQX should increment a failure counter.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update