-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When the ScrollBar is set to Visibility::AlwaysVisible, scrolling is always possible & contains pointer #4348
Closed
Closed
Changes from 33 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
f0b7737
Update memory.rs
rustbasic 3b98d7f
Update epi_integration.rs
rustbasic af5a7bb
Update memory.rs
rustbasic 7f66b56
Update memory.rs
rustbasic 6396c4a
Update epi_integration.rs
rustbasic 9fe42ff
Merge branch 'emilk:master' into master
rustbasic d7673fe
Merge branch 'emilk:master' into master
rustbasic a7edc53
Merge branch 'emilk:master' into master
rustbasic 2432784
Merge branch 'emilk:master' into master
rustbasic 9b6209b
Merge branch 'emilk:master' into master
rustbasic f3687f6
Merge branch 'emilk:master' into master
rustbasic 78880de
Merge branch 'emilk:master' into master
rustbasic 01ba2ec
Merge branch 'emilk:master' into master
rustbasic 0ae2451
Merge branch 'emilk:master' into master
rustbasic e6c84ce
Merge branch 'emilk:master' into master
rustbasic 821dff0
Update epi_integration.rs
rustbasic eecfafd
Merge branch 'emilk:master' into master
rustbasic cbb5ac7
Merge branch 'emilk:master' into master
rustbasic 07b5143
Merge branch 'emilk:master' into master
rustbasic 3313633
Update epi_integration.rs
rustbasic 90b968c
Merge branch 'emilk:master' into master
rustbasic 13af44f
Merge branch 'emilk:master' into master
rustbasic 5d95f09
Merge branch 'emilk:master' into master
rustbasic 4be440a
Merge branch 'emilk:master' into master
rustbasic 1ef0e10
Merge branch 'emilk:master' into master
rustbasic 6541324
Merge branch 'emilk:master' into master
rustbasic 8abc161
Merge branch 'emilk:master' into master
rustbasic 1b21742
Merge branch 'emilk:master' into master
rustbasic 052bb68
Merge branch 'emilk:master' into master
rustbasic a3fc209
Update input_state.rs
rustbasic 9d01bef
Update scroll_area.rs
rustbasic aff6dd9
Update scroll_area.rs
rustbasic 303ba20
Merge branch 'emilk:master' into patch40
rustbasic 3e49063
Merge branch 'emilk:master' into patch40
rustbasic 1420c26
Merge branch 'emilk:master' into patch40
rustbasic 734e21a
Merge branch 'emilk:master' into patch40
rustbasic 8c1294e
Merge branch 'emilk:master' into patch40
rustbasic 2af3a46
Merge branch 'emilk:master' into patch40
rustbasic File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like a bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no problem if I remove this from Windows.
I left it here to hear 'emilk's opinion on whether it can be removed.
If something is wrong or needs to be fixed, please fix it or let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment effectively ignores
raw_scroll_delta
and all the work that went into smoothing it, breaking the existing smooth scrolling of everything except for ScrollAreas (e.g. scroll-to-zoom in a plot).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edited as #4412