Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the support for old Embulk v0.9 SPIs #4

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Remove the support for old Embulk v0.9 SPIs #4

merged 1 commit into from
Jul 25, 2023

Conversation

dmikurube
Copy link
Member

This embulk-parser-json:0.11.* is expected to run with Embulk v0.11, no longer with Embulk v0.9. It no longer needs to take care of the old SPI.

@dmikurube dmikurube added this to the v0.11.1 milestone Jul 25, 2023
@dmikurube dmikurube requested a review from a team as a code owner July 25, 2023 07:22
hiroyuki-sato
hiroyuki-sato approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

Base automatically changed from bump-up-to-v0.11.1 to main July 25, 2023 11:10
@dmikurube
Copy link
Member Author

Thanks!

@dmikurube dmikurube merged commit 33d8aa7 into main Jul 25, 2023
4 checks passed
@dmikurube dmikurube deleted the remove-v0.9-spi branch July 25, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroyuki-sato hiroyuki-sato hiroyuki-sato approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.11.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmikurube @hiroyuki-sato