Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows short path alias 8.3 #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

patricklx
Copy link

No description provided.

@ef4
Copy link
Collaborator

ef4 commented May 16, 2024

This seems like a bug in the very-old tmp package that is generating these paths. I don't think this kind of workaround belongs in scenario-tester.

@patricklx
Copy link
Author

This seems like a bug in the very-old tmp package that is generating these paths. I don't think this kind of workaround belongs in scenario-tester.

mm, i did not find any open issues about it. i'm talking about this:
https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#short-vs-long-names

its a windows thing. tmp package does not have control over that. it can be disabled via windows registry... but thats not possible on github runners. it should really be disabled by default.

there is some discussion here as well: actions/runner-images#712

@patricklx
Copy link
Author

maybe we can just change the TEMP var:
https://stackoverflow.com/a/39259598

@ef4
Copy link
Collaborator

ef4 commented May 17, 2024

Some global fix like that would be better. Because I doubt this is the only spot that would be unhappy about being unable to rely on a canonical path being consistent. This same kind of thing would definitely break the PackageCache, for example. If you search for all the places that embroider uses realpathSync you'll see several examples.

@patricklx
Copy link
Author

Some global fix like that would be better. Because I doubt this is the only spot that would be unhappy about being unable to rely on a canonical path being consistent. This same kind of thing would definitely break the PackageCache, for example. If you search for all the places that embroider uses realpathSync you'll see several examples.

The global fix would only work for tmp.
I do not think realpathsync does have the issue. I would probably already have seen it if it does.
It mostly does string manipulation. Only fir symlinks it uses os calls. Which should be save as long as the project is setup within a non short path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants