This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
Fixed infinite loop when using loadSaveData triggering onChange #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to be related to #93. Thanks for creating the PR! |
|
Hi @embiem @parbhatia! Thanks for this awesome package and this PR - may I ask, what is the status of this branch? Is there any way I can try to help progress this PR? :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit rushed, this is what I changed to stop infinite rendering when using socket.io and multiple listeners. The basic problem being the inability to stop triggering
onChangewhen loading saved data.If
loadSaveDatais provided with a third boolean parametertriggerChange: false, we skip triggering the providedonChangefunction.If no
triggerChangeis provided, it's business as usual.