Skip to content

Commit

Permalink
[Bug Fix] Make claude-3-opus model work (#1331)
Browse files Browse the repository at this point in the history
  • Loading branch information
deshraj committed Mar 28, 2024
1 parent 85ec613 commit d00a208
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 26 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ install:

install_all:
poetry install --all-extras
poetry run pip install pinecone-text pinecone-client
poetry run pip install pinecone-text pinecone-client langchain-anthropic

install_es:
poetry install --extras elasticsearch
Expand Down
8 changes: 6 additions & 2 deletions embedchain/llm/anthropic.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
import os
from typing import Optional

try:
from langchain_anthropic import ChatAnthropic
except ImportError:
raise ImportError("Please install the langchain-anthropic package by running `pip install langchain-anthropic`.")

from embedchain.config import BaseLlmConfig
from embedchain.helpers.json_serializable import register_deserializable
from embedchain.llm.base import BaseLlm
Expand All @@ -21,10 +26,9 @@ def get_llm_model_answer(self, prompt):

@staticmethod
def _get_answer(prompt: str, config: BaseLlmConfig) -> str:
from langchain_community.chat_models import ChatAnthropic

chat = ChatAnthropic(
anthropic_api_key=os.environ["ANTHROPIC_API_KEY"], temperature=config.temperature, model=config.model
anthropic_api_key=os.environ["ANTHROPIC_API_KEY"], temperature=config.temperature, model_name=config.model
)

if config.max_tokens and config.max_tokens != 1000:
Expand Down
1 change: 0 additions & 1 deletion embedchain/vectordb/qdrant.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import copy
import os
import uuid
from typing import Any, Optional, Union

try:
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[tool.poetry]
name = "embedchain"
version = "0.1.98"
description = "Simplest open source retrieval(RAG) framework"
version = "0.1.99"
description = "Simplest open source retrieval (RAG) framework"
authors = [
"Taranjeet Singh <[email protected]>",
"Deshraj Yadav <[email protected]>",
Expand Down
21 changes: 1 addition & 20 deletions tests/llm/test_anthrophic.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import os
from unittest.mock import MagicMock, patch
from unittest.mock import patch

import pytest
from langchain.schema import HumanMessage, SystemMessage
Expand All @@ -23,25 +23,6 @@ def test_get_llm_model_answer(anthropic_llm):
mock_method.assert_called_once_with(prompt=prompt, config=anthropic_llm.config)


def test_get_answer(anthropic_llm):
with patch("langchain_community.chat_models.ChatAnthropic") as mock_chat:
mock_chat_instance = mock_chat.return_value
mock_chat_instance.return_value = MagicMock(content="Test Response")

prompt = "Test Prompt"
response = anthropic_llm._get_answer(prompt, anthropic_llm.config)

assert response == "Test Response"
mock_chat.assert_called_once_with(
anthropic_api_key="test_api_key",
temperature=anthropic_llm.config.temperature,
model=anthropic_llm.config.model,
)
mock_chat_instance.assert_called_once_with(
anthropic_llm._get_messages(prompt, system_prompt=anthropic_llm.config.system_prompt)
)


def test_get_messages(anthropic_llm):
prompt = "Test Prompt"
system_prompt = "Test System Prompt"
Expand Down

0 comments on commit d00a208

Please sign in to comment.