Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup GitHub actions #14

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Setup GitHub actions #14

merged 2 commits into from
Mar 19, 2024

Conversation

jclusso
Copy link
Member

@jclusso jclusso commented Mar 18, 2024

  • Add RuboCop
  • Refactor tests
  • Fix failing lints
  • Remove travis
  • Add dependabot config

@jclusso
Setup GitHub actions
db9d318 
- Add RuboCop
- Refactor tests
- Fix failing lints
- Remove travis
- Add dependabot config
@jclusso jclusso requested a review from eberquist March 18, 2024 16:39
eberquist
eberquist reviewed Mar 19, 2024
View reviewed changes
Copy link
Contributor

@eberquist eberquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on things that don't make sense to me.

test/email_validator_test.rb Show resolved Hide resolved
test/email_validator_test.rb Outdated Show resolved Hide resolved
@jclusso jclusso requested a review from eberquist March 19, 2024 13:44
@jclusso jclusso merged commit d37de93 into master Mar 19, 2024
6 checks passed
@jclusso jclusso deleted the setup_gh_actions branch March 19, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eberquist eberquist eberquist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jclusso @eberquist