Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes validation of pipelines that contain both pipeline params and default properties. #3195

Merged
merged 1 commit into from May 19, 2024

Conversation

rkpattnaik780
Copy link
Contributor

What changes were proposed in this pull request?

Fixes validation of pipelines that contain both pipeline parameters and default properties.

Fixes #3190

How was this pull request tested?

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@rkpattnaik780 rkpattnaik780 changed the title WIP: fix: rebuild subclass map with runtime class fix: rebuild subclass map with runtime class Nov 9, 2023
@lresende
Copy link
Member

lresende commented Nov 9, 2023

Please update/fix the lint issues

@lresende lresende changed the title fix: rebuild subclass map with runtime class Fixes validation of pipelines that contain both pipeline params and default properties. Nov 10, 2023
@rkpattnaik780 rkpattnaik780 force-pushed the fix_validate branch 2 times, most recently from 086e0a0 to 6b370fc Compare November 13, 2023 10:29
@rkpattnaik780
Copy link
Contributor Author

Please update/fix the lint issues

Done, the Test Server was failing for version 3.11, fix for which has been raised in #3197 .

Copy link
Contributor

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR 💯
This works like a charm.

(app-root) (app-root) elyra-pipeline validate untitled.pipeline 

────────────────────────────────────────────────────────────────
 Elyra Pipeline Validation
────────────────────────────────────────────────────────────────

Validating pipeline...

❯ Pipeline validation SUCCEEDED.

@lresende lresende closed this Jan 12, 2024
@lresende lresende reopened this Jan 12, 2024
@rkpattnaik780 rkpattnaik780 force-pushed the fix_validate branch 2 times, most recently from 55e5009 to a99f4dc Compare February 6, 2024 09:44
@rkpattnaik780
Copy link
Contributor Author

The PR has been rebased and updated to fix the linting issues. All checks are now passing.

Cc @lresende

@lresende lresende merged commit bb608d3 into elyra-ai:main May 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elyra-pipeline validate CLI command fails for pipelines with parameters and default properties
3 participants