Add range_select function to simple expr
#628
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,4 @@ | |||
| [toolchain] | |||
| channel = "nightly-2022-08-27" | |||
There was a problem hiding this comment.
Why the nightly bump?
There was a problem hiding this comment.
I wanted to use the now stable let ... else I think. Not really necessary, though.
| @@ -341,13 +346,39 @@ fn call_expr_function(name: &str, args: Vec<DynVal>) -> Result<DynVal, EvalError | |||
| [json] => Ok(DynVal::from(json.as_json_object()?.len() as i32)), | |||
| _ => Err(EvalError::WrongArgCount(name.to_string())), | |||
| }, | |||
| "range_select" => match args.as_slice() { | |||
There was a problem hiding this comment.
Could you add the function to the docs here: https://github.com/elkowar/eww/blob/master/docs/src/expression_language.md
There was a problem hiding this comment.
Will do. Wanted to finalize the design a little in #622
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #622
Please follow this template, if applicable.
Description
Adds
range_selectfunction. PoC.Usage
When adding a widget or anything else that affects the configuration,
please provide a minimal example configuration snippet showcasing how to use it and
Showcase
When adding widgets, please provide screenshots showcasing how your widget looks.
This is not strictly required, but strongly appreciated.
Additional Notes
Anything else you want to add, such as remaining questions or explanations.
Checklist
Please make sure you can check all the boxes that apply to this PR.
docs/content/maindirectory has been adjusted to reflect my changes.cargo fmtto automatically format all code before committing