Add support for sigils containing integers #13448
Conversation
This commit adds support for sigils containing integers. Integers must be proceeded by an upper case alpha, but can otherwise be mixed (e.g., `~A1B2C3`).
|
Note: I will update sigil docs when a signal this is to be accepted is received :) |
|
I come here with zero context. Was this discussed in the ML or somewhere else? |
As is tradition, I give you a context fail 😄 No, this was not discussed on the ML, it simply came up informally on EEF slack. The original context is a potential need to add a sigil that corresponds to a library name that ends with a digit |
|
Gotcha @starbelly no probs, I was just checking. Thanks for the info. 🙏 |
whatyouhide
changed the title
Co-authored-by: José Valim <[email protected]>
|
@josevalim I think this is good now, but let me know if more adjustments should be made. |
| {ok, lists:reverse(NameAcc), T, Line, Column, Scope, Tokens}. | ||
|
|
||
| sigil_name_error() -> |
There was a problem hiding this comment.
This could also be a macro, not sure what the preference here. Likewise, we could just place the error tuple here, but once again, not sure the preference (localization of such things can be valuable).
Co-authored-by: Matt Furden <[email protected]>
Co-authored-by: Matt Furden <[email protected]>
|
💚 💙 💜 💛 ❤️ |
This commit adds support for sigils containing integers. Integers must be proceeded by an upper case alpha, but can otherwise be mixed (e.g.,
~A1B2C3).