Rewrite tests #69
Open
Rewrite tests #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔔 |
|
@beck whitespace is long overdue |
|
@englishextra agreed and that refactoring can be done confidently when there are good tests to ensure breakage doesn't happen. That's what I'm trying to add with this pull, unblocking the other items on the roadmap. |
Using webdriver.io. Also tried karma, grunt plugins, and nightwatch.js. All required way too much scaffolding. E2E testing is a pain because you need three processes: * http server * web driver server (or a proxy server for cloud browsers) * test runner `wdio.conf.js` makes this easy to bake into one call. Misc thoughts: * webdriver.io API is synchronous, making it significantly easier to write clean tests. * Mocha formatted tests seem to "just work" out of the box (not so with nightwatch) * The config is easy to set up (and includes a wizard) * Nightwatch made it hard/impossible to skip tests
beck
referenced
this pull request
in yola/classlist-polyfill
Jan 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This adds:
https://travis-ci.org/beck/classlist-polyfill/builds/326606954
The first item on the roadmap: #64
Note: this pull is a lot larger than I prefer but see it as an exception since it is adding all new test scaffolding and coverage. It should be reviewable by commit.