Spelling: Link, Terminal emulator desc #609
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
requested changes
Jul 19, 2021
There was a problem hiding this comment.
Thanks for the suggestions! In elementary OS we use the term "secondary click" instead of "right click", because it is device agnostic. Many users are using laptops with multitouch two-finger secondary clicking and for those users the term "right click" doesn't make sense
jeremypw
requested changes
Oct 13, 2021
| @@ -40,7 +40,7 @@ | |||
| <li>Zoom levels are now remembered per-tab</li> | |||
| <li>Also warn about multi-line pastes</li> | |||
| <li>Show text details in unsafe paste dialogs</li> | |||
| <li>Open Link option when secondary clicking</li> | |||
| <li>Open link options when right-clicking</li> | |||
There was a problem hiding this comment.
As @danrabbit pointed out "secondary click" should be used. However the whole item is not very precise in meaning so if it is to be changed it might as well be improved. It refers to adding another option to the context menu shown when secondary-clicking on a hyperlink in the terminal text. I would suggest something like
<li>Add "Open in" option to the context menu of links</li>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.