Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display custom test name if available #1374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

display custom test name if available #1374

wants to merge 1 commit into from

Conversation

yatsky
Copy link

@yatsky yatsky commented Jan 16, 2024

This fixes #1224.

Please let me know if it needs more work.
Thanks.

@haritamar
Copy link
Collaborator

Hi @yatsky !
Thanks a lot for this contribution and sorry for the delay in our response.
We'll look into it as soon as we can - intuitively it requires verifying on our end that it doesn't break other behaviors and works with previous dbt versions (we support dbt 1.3.0 and above today).

Thanks,
Itamar

@haritamar
Copy link
Collaborator

Hi @yatsky !
Following up here - I think that the implemented heuristic doesn't work well when the tests are defined on sources:
image

So that would need to be fixed before we can merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Awaiting Response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom test name does not show in report html file
2 participants
@yatsky @haritamar