Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(components): @touchstart @touchmove @wheel add passive #16741

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

warmthsea
Copy link
Contributor

@warmthsea warmthsea commented May 2, 2024

image
image

After:

image
image

Copy link

👋 @warmthsea, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

Copy link

github-actions bot commented May 2, 2024

Copy link

github-actions bot commented May 2, 2024

Hello @warmthsea, thank you for contributing to element-plus, please see our guideline to see how to make contribution

Copy link

github-actions bot commented May 2, 2024

🧪 Playground Preview: https://element-plus.run/?pr=16741
Please comment the example via this playground if needed.

@warmthsea
Copy link
Contributor Author

I have another question:
#16742

packages/components/slider/src/slider.vue Outdated Show resolved Hide resolved
packages/components/color-picker/src/utils/draggable.ts Outdated Show resolved Hide resolved
packages/components/slider/src/button.vue Outdated Show resolved Hide resolved
@warmthsea warmthsea changed the title perf(components): @touchstart @touchmove add passive perf(components): @touchstart @touchmove @wheel add passive May 3, 2024
@btea btea changed the title perf(components): @touchstart @touchmove @wheel add passive improvement(components): @touchstart @touchmove @wheel add passive May 3, 2024
@btea
Copy link
Collaborator

btea commented May 3, 2024

The touchmove event here can also be handled. A warning message will also appear when dragging the scroll bar of table-v2.

thumbEl.addEventListener('touchmove', onMouseMove)

@vettndr
Copy link

vettndr commented Jun 2, 2024

Hello guys,
I'm facing a warning inside the date-picker component.
This is the issue I found related to this pr.

#16282

@warmthsea
Copy link
Contributor Author

warmthsea commented Jun 2, 2024

Hello guys,

I'm facing a warning inside the date-picker component.

This is the issue I found related to this pr.

#16282

It needs to be approved by other auditors before it can be merged into the main branch.

In fact, the warning existed from the beginning until now.

@vettndr
Copy link

vettndr commented Jun 3, 2024

Hello guys,
I'm facing a warning inside the date-picker component.
This is the issue I found related to this pr.
#16282

It needs to be approved by other auditors before it can be merged into the main branch.

In fact, the warning existed from the beginning until now.

yes, of course.
I wrote here to underline that also in the date picker there is the warning message.
If this pr is related to all the library components I hope It will be soon close.

@warmthsea
Copy link
Contributor Author

Hello guys,
I'm facing a warning inside the date-picker component.
This is the issue I found related to this pr.
#16282

It needs to be approved by other auditors before it can be merged into the main branch.
In fact, the warning existed from the beginning until now.

yes, of course. I wrote here to underline that also in the date picker there is the warning message. If this pr is related to all the library components I hope It will be soon close.

date-picker seems to be no warning, this PR has not been modified to.
Can you provide detailed screenshots and reports? If the problem is the same as the one solved by this PR, I will make the changes as well.

image

@btea btea requested review from chenxch and kooriookami June 3, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants