Fixing issue with list ctor that differs from stl (wasn't documented) #469
+29
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e T which would then be copied over while the standard says that no copies are made
if the function was called with arithmetic type, the value would not be zero initialized.
|
Hello, Thanks for the PR, what's here looks good to me but it looks like we don't have a CLA for you on file yet. Could you please fill out this form? Also, it'd be good to have a test to |
…ault constructed element
|
@grojo-ea I've added the tests and filled in the CLA now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(https://en.cppreference.com/w/cpp/container/list/list)
constructor 4) dictates: "Constructs the container with count default-inserted instances of T. No copies are made."
However, EASTL created a default constructed object which would then be copied into the nodes.
No default object is constructed now and the parameter-less overload of DoCreateNode is now used to create the nodes.