feat: exit app instance when main package throws error on load

.github/dependabot.yml

@@ -0,0 +1,9 @@
+# Keep GitHub Actions up to date with GitHub's Dependabot...
+# https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot
+# https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#package-ecosystem
+version: 2
+updates:
+ - package-ecosystem: github-actions
+ directory: /
+ schedule:
+ interval: weekly

.github/workflows/issue-labeled.yml

@@ -70,7 +70,7 @@ jobs:
  creds: ${{ secrets.ISSUE_TRIAGE_GH_APP_CREDS }}
  - name: Create comment
  if: ${{ steps.check-for-comment.outputs.SHOULD_COMMENT }}
- uses: actions-cool/issues-helper@275328970dbc3bfc3bc43f5fe741bf3638300c0a # v3.3.3
+ uses: actions-cool/issues-helper@a610082f8ac0cf03e357eb8dd0d5e2ba075e017e # v3.6.0
  with:
  actions: 'create-comment'
  token: ${{ steps.generate-token.outputs.token }}

.github/workflows/issue-opened.yml

@@ -35,7 +35,7 @@ jobs:
  with:
  creds: ${{ secrets.ISSUE_TRIAGE_GH_APP_CREDS }}
  org: electron
- - run: npm install [email protected] [email protected]
+ - run: npm install [email protected] [email protected] [email protected]
  - name: Add labels
  uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
  env:
@@ -45,6 +45,7 @@ jobs:
  script: |
  const { fromMarkdown } = await import('${{ github.workspace }}/node_modules/mdast-util-from-markdown/index.js');
  const { select } = await import('${{ github.workspace }}/node_modules/unist-util-select/index.js');
+ const semver = await import('${{ github.workspace }}/node_modules/semver/index.js');
 
  const [ owner, repo ] = '${{ github.repository }}'.split('/');
  const issue_number = ${{ github.event.issue.number }};
@@ -53,6 +54,28 @@ jobs:
 
  const labels = [];
 
+ const electronVersion = select('heading:has(> text[value="Electron Version"]) + paragraph > text', tree)?.value.trim();
+ if (electronVersion !== undefined) {
+ const major = semver.parse(electronVersion)?.major;
+ if (major) {
+ const versionLabel = `${major}-x-y`;
+ let labelExists = false;
+
+ try {
+ await github.rest.issues.getLabel({
+ owner,
+ repo,
+ name: versionLabel,
+ });
+ labelExists = true;
+ } catch {}
+
+ if (labelExists) {
+ labels.push(versionLabel);
+ }
+ }
+ }
+
  const gistUrl = select('heading:has(> text[value="Testcase Gist URL"]) + paragraph > text', tree)?.value.trim();
  if (gistUrl !== undefined && gistUrl.startsWith('https://gist.github.com/')) {
  labels.push('has-repro-gist');

.github/workflows/pull-request-labeled.yml

@@ -13,7 +13,7 @@ jobs:
  runs-on: ubuntu-latest
  steps:
  - name: Trigger Slack workflow
- uses: slackapi/slack-github-action@6c661ce58804a1a20f6dc5fbee7f0381b469e001 # v1.25.0
+ uses: slackapi/slack-github-action@70cd7be8e40a46e8b0eced40b0de447bdb42f68e # v1.26.0
  with:
  payload: |
  {

.github/workflows/scorecards.yml

@@ -50,6 +50,6 @@ jobs:
 
  # Upload the results to GitHub's code scanning dashboard.
  - name: "Upload to code-scanning"
- uses: github/codeql-action/upload-sarif@e8893c57a1f3a2b659b6b55564fdfdbbd2982911 # v3.24.0
+ uses: github/codeql-action/upload-sarif@d39d31e687223d841ef683f52467bd88e9b21c14 # v3.25.3
  with:
  sarif_file: results.sarif

.github/workflows/update_appveyor_image.yml

@@ -39,7 +39,7 @@ jobs:
  fi
  - name: (Optionally) Update Appveyor Image
  if: ${{ env.APPVEYOR_IMAGE_VERSION }}
- uses: mikefarah/yq@bb66c9c872a7a4cf3d6846c2ff6d182c66ec3f77 # v4.40.7
+ uses: mikefarah/yq@c35ec752e38ea0c096d3c44e13cfc0797ac394d8 # v4.43.1
  with:
  cmd: |
  yq '.image = "${{ env.APPVEYOR_IMAGE_VERSION }}"' "appveyor.yml" > "appveyor2.yml"

.lint-roller.json

@@ -0,0 +1,13 @@
+{
+ "markdown-ts-check": {
+ "defaultImports": [
+ "import * as childProcess from 'node:child_process'",
+ "import * as fs from 'node:fs'",
+ "import * as path from 'node:path'",
+ "import { app, autoUpdater, contextBridge, crashReporter, dialog, BrowserWindow, ipcMain, ipcRenderer, Menu, MessageChannelMain, nativeImage, net, protocol, session, systemPreferences, Tray, utilityProcess, webFrame, webFrameMain } from 'electron'"
+ ],
+ "typings": [
+ "../electron.d.ts"
+ ]
+ }
+}

.markdownlint.json

@@ -1,6 +1,7 @@
 {
  "extends": "@electron/lint-roller/configs/markdownlint.json",
  "no-angle-brackets": true,
+ "no-curly-braces": true,
  "no-inline-html": {
  "allowed_elements": [
  "br",

BUILD.gn

@@ -81,18 +81,11 @@ if (is_linux) {
  ]
  }
 
- # Generates electron_gtk_stubs.h header which contains
- # stubs for extracting function ptrs from the gtk library.
- # Function signatures for which stubs are required should be
- # declared in electron_gtk.sigs, currently this file contains
- # signatures for the functions used with native file chooser
- # implementation. In future, this file can be extended to contain
- # gtk4 stubs to switch gtk version in runtime.
+ # Generates headers which contain stubs for extracting function ptrs
+ # from the gtk library. Function signatures for which stubs are
+ # required should be declared in the sig files.
  generate_stubs("electron_gtk_stubs") {
- sigs = [
- "shell/browser/ui/electron_gdk_pixbuf.sigs",
- "shell/browser/ui/electron_gtk.sigs",
- ]
+ sigs = [ "shell/browser/ui/electron_gdk_pixbuf.sigs" ]
  extra_header = "shell/browser/ui/electron_gtk.fragment"
  output_name = "electron_gtk_stubs"
  public_deps = [ "//ui/gtk:gtk_config" ]
@@ -665,6 +658,7 @@ source_set("electron_lib") {
  libs += [ "dwmapi.lib" ]
  sources += [ "shell/common/asar/archive_win.cc" ]
  deps += [
+ "//components/app_launch_prefetch",
  "//components/crash/core/app:crash_export_thunks",
  "//ui/native_theme:native_theme_browser",
  "//ui/wm",

DEPS

@@ -2,9 +2,9 @@ gclient_gn_args_from = 'src'
 
 vars = {
  'chromium_version':
- '125.0.6412.0',
+ '126.0.6445.0',
  'node_version':
- 'v20.12.2',
+ 'v20.13.1',
  'nan_version':
  'e14bdcd1f72d62bca1d541b66da43130384ec213',
  'squirrel.mac_version':
@@ -161,6 +161,54 @@ hooks = [
  'import os, subprocess; os.chdir(os.path.join("src", "electron")); subprocess.check_call(["python3", "script/lib/npx.py", "yarn@' + (Var("yarn_version")) + '", "install", "--frozen-lockfile"]);',
  ],
  },
+ {
+ 'name': 'sysroot_arm',
+ 'pattern': '.',
+ 'condition': 'checkout_linux and checkout_arm',
+ 'action': ['python3', 'src/build/linux/sysroot_scripts/install-sysroot.py',
+ '--sysroots-json-path=' + Var('sysroots_json_path'),
+ '--arch=arm'],
+ },
+ {
+ 'name': 'sysroot_arm64',
+ 'pattern': '.',
+ 'condition': 'checkout_linux and checkout_arm64',
+ 'action': ['python3', 'src/build/linux/sysroot_scripts/install-sysroot.py',
+ '--sysroots-json-path=' + Var('sysroots_json_path'),
+ '--arch=arm64'],
+ },
+ {
+ 'name': 'sysroot_x86',
+ 'pattern': '.',
+ 'condition': 'checkout_linux and (checkout_x86 or checkout_x64)',
+ 'action': ['python3', 'src/build/linux/sysroot_scripts/install-sysroot.py',
+ '--sysroots-json-path=' + Var('sysroots_json_path'),
+ '--arch=x86'],
+ },
+ {
+ 'name': 'sysroot_mips',
+ 'pattern': '.',
+ 'condition': 'checkout_linux and checkout_mips',
+ 'action': ['python3', 'src/build/linux/sysroot_scripts/install-sysroot.py',
+ '--sysroots-json-path=' + Var('sysroots_json_path'),
+ '--arch=mips'],
+ },
+ {
+ 'name': 'sysroot_mips64',
+ 'pattern': '.',
+ 'condition': 'checkout_linux and checkout_mips64',
+ 'action': ['python3', 'src/build/linux/sysroot_scripts/install-sysroot.py',
+ '--sysroots-json-path=' + Var('sysroots_json_path'),
+ '--arch=mips64el'],
+ },
+ {
+ 'name': 'sysroot_x64',
+ 'pattern': '.',
+ 'condition': 'checkout_linux and checkout_x64',
+ 'action': ['python3', 'src/build/linux/sysroot_scripts/install-sysroot.py',
+ '--sysroots-json-path=' + Var('sysroots_json_path'),
+ '--arch=x64'],
+ },
 ]
 
 recursedeps = [

appveyor-woa.yml

@@ -29,7 +29,7 @@
 
 version: 1.0.{build}
 build_cloud: electronhq-16-core
-image: e-125.0.6412.0
+image: e-126.0.6445.0
 environment:
  GIT_CACHE_PATH: C:\Users\appveyor\libcc_cache
  ELECTRON_OUT_DIR: Default

appveyor.yml

@@ -29,7 +29,7 @@
 
 version: 1.0.{build}
 build_cloud: electronhq-16-core
-image: e-125.0.6412.0
+image: e-126.0.6445.0
 environment:
  GIT_CACHE_PATH: C:\Users\appveyor\libcc_cache
  ELECTRON_OUT_DIR: Default

build/args/all.gn

@@ -64,3 +64,12 @@ v8_enable_private_mapping_fork_optimization = true
 
 # Expose public V8 symbols for native modules.
 v8_expose_public_symbols = true
+
+# Disables unsafe-buffers-usage plugin due to incompatibilities with our reclient implementation
+# Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5426599
+# Ref: https://github.com/electron/electron/commit/8e20f16ea35eeaeb149ae63bad3703d782665f6a
+clang_unsafe_buffers_paths = ""
+
+# Disable snapshotting a page when printing for its content to be analyzed for
+# sensitive content by enterprise users.
+enterprise_content_analysis = false

default_app/main.ts

@@ -137,9 +137,7 @@ async function loadApplicationPackage (packagePath: string) {
  // Run the app.
  await import(url.pathToFileURL(filePath).toString());
  } catch (e) {
- console.error('App threw an error during load');
- console.error((e as Error).stack || e);
- throw e;
+ showErrorMessage(`App threw an error during load of ${packagePath}\n\n${(e as Error).stack || (e as Error).message || e}`);
  }
 }
 

docs/api/base-window.md

@@ -600,7 +600,7 @@ Perhaps there are 15 pixels of controls on the left edge, 25 pixels of controls
 on the right edge and 50 pixels of controls below the player. In order to
 maintain a 16:9 aspect ratio (standard aspect ratio for HD @1920x1080) within
 the player itself we would call this function with arguments of 16/9 and
-{ width: 40, height: 50 }. The second argument doesn't care where the extra width and height
+\{ width: 40, height: 50 \}. The second argument doesn't care where the extra width and height
 are within the content view--only that they exist. Sum any extra width and
 height areas you have within the overall content view.
 

docs/api/browser-window.md

@@ -723,7 +723,7 @@ Perhaps there are 15 pixels of controls on the left edge, 25 pixels of controls
 on the right edge and 50 pixels of controls below the player. In order to
 maintain a 16:9 aspect ratio (standard aspect ratio for HD @1920x1080) within
 the player itself we would call this function with arguments of 16/9 and
-{ width: 40, height: 50 }. The second argument doesn't care where the extra width and height
+\{ width: 40, height: 50 \}. The second argument doesn't care where the extra width and height
 are within the content view--only that they exist. Sum any extra width and
 height areas you have within the overall content view.
 

docs/api/context-bridge.md

@@ -129,7 +129,7 @@ has been included below for completeness:
 | `Object` | Complex | ✅ | ✅ | Keys must be supported using only "Simple" types in this table. Values must be supported in this table. Prototype modifications are dropped. Sending custom classes will copy values but not the prototype. |
 | `Array` | Complex | ✅ | ✅ | Same limitations as the `Object` type |
 | `Error` | Complex | ✅ | ✅ | Errors that are thrown are also copied, this can result in the message and stack trace of the error changing slightly due to being thrown in a different context, and any custom properties on the Error object [will be lost](https://github.com/electron/electron/issues/25596) |
-| `Promise` | Complex | ✅ | ✅ | N/A
+| `Promise` | Complex | ✅ | ✅ | N/A |
 | `Function` | Complex | ✅ | ✅ | Prototype modifications are dropped. Sending classes or constructors will not work. |
 | [Cloneable Types](https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Structured_clone_algorithm) | Simple | ✅ | ✅ | See the linked document on cloneable types |
 | `Element` | Complex | ✅ | ✅ | Prototype modifications are dropped. Sending custom elements will not work. |

docs/api/net.md

@@ -66,7 +66,7 @@ requests according to the specified protocol scheme in the `options` object.
 ### `net.fetch(input[, init])`
 
 * `input` string | [GlobalRequest](https://nodejs.org/api/globals.html#request)
-* `init` [RequestInit](https://developer.mozilla.org/en-US/docs/Web/API/fetch#options) & { bypassCustomProtocolHandlers?: boolean } (optional)
+* `init` [RequestInit](https://developer.mozilla.org/en-US/docs/Web/API/fetch#options) & \{ bypassCustomProtocolHandlers?: boolean \} (optional)
 
 Returns `Promise<GlobalResponse>` - see [Response](https://developer.mozilla.org/en-US/docs/Web/API/Response).
 

docs/api/protocol.md

@@ -9,10 +9,14 @@ An example of implementing a protocol that has the same effect as the
 
 ```js
 const { app, protocol, net } = require('electron')
+const path = require('node:path')
+const url = require('node:url')
 
 app.whenReady().then(() => {
- protocol.handle('atom', (request) =>
- net.fetch('file://' + request.url.slice('atom://'.length)))
+ protocol.handle('atom', (request) => {
+ const filePath = request.url.slice('atom://'.length)
+ return net.fetch(url.pathToFileURL(path.join(__dirname, filePath)).toString())
+ })
 })
 ```
 
@@ -42,7 +46,7 @@ app.whenReady().then(() => {
 
  ses.protocol.handle('atom', (request) => {
  const filePath = request.url.slice('atom://'.length)
- return net.fetch(url.pathToFileURL(path.join(__dirname, filePath)).toString())
+ return net.fetch(url.pathToFileURL(path.resolve(__dirname, filePath)).toString())
  })
 
  const mainWindow = new BrowserWindow({ webPreferences: { partition } })

docs/api/session.md

@@ -695,7 +695,7 @@ Returns `Promise<void>` - Resolves when all connections are closed.
 #### `ses.fetch(input[, init])`
 
 * `input` string | [GlobalRequest](https://nodejs.org/api/globals.html#request)
-* `init` [RequestInit](https://developer.mozilla.org/en-US/docs/Web/API/fetch#options) & { bypassCustomProtocolHandlers?: boolean } (optional)
+* `init` [RequestInit](https://developer.mozilla.org/en-US/docs/Web/API/fetch#options) & \{ bypassCustomProtocolHandlers?: boolean \} (optional)
 
 Returns `Promise<GlobalResponse>` - see [Response](https://developer.mozilla.org/en-US/docs/Web/API/Response).
 

docs/api/view.md

@@ -48,6 +48,9 @@ Objects created with `new View` have the following instance methods:
 * `index` Integer (optional) - Index at which to insert the child view.
  Defaults to adding the child at the end of the child list.
 
+If the same View is added to a parent which already contains it, it will be reordered such that
+it becomes the topmost view.
+
 #### `view.removeChildView(view)`
 
 * `view` View - Child view to remove.

docs/breaking-changes.md

@@ -14,6 +14,12 @@ This document uses the following convention to categorize breaking changes:
 
 ## Planned Breaking API Changes (31.0)
 
+### Removed: `WebSQL` support
+
+Chromium has removed support for WebSQL upstream, transitioning it to Android only. See
+[Chromium's intent to remove discussion](https://groups.google.com/a/chromium.org/g/blink-dev/c/fWYb6evVA-w/m/wGI863zaAAAJ)
+for more information.
+
 ### Behavior Changed: `nativeImage.toDataURL` will preseve PNG colorspace
 
 PNG decoder implementation has been changed to preserve colorspace data, the

docs/development/coding-style.md

@@ -41,7 +41,7 @@ etc.
 
 * Write [remark](https://github.com/remarkjs/remark) markdown style.
 
-You can run `npm run lint-docs` to ensure that your documentation changes are
+You can run `npm run lint:docs` to ensure that your documentation changes are
 formatted correctly.
 
 ## JavaScript

docs/development/debugging-with-symbol-server.md

@@ -15,7 +15,7 @@ calls, and other compiler optimizations. The only workaround is to build an
 unoptimized local build.
 
 The official symbol server URL for Electron is
-<https://symbols.electronjs.org>.
+[https://symbols.electronjs.org](https://symbols.electronjs.org).
 You cannot visit this URL directly, you must add it to the symbol path of your
 debugging tool. In the examples below, a local cache directory is used to avoid
 repeatedly fetching the PDB from the server. Replace `c:\code\symbols` with an

docs/fiddles/features/dark-mode/index.html

@@ -14,6 +14,5 @@ <h1>Hello World!</h1>
  <button id="reset-to-system">Reset to System Theme</button>
 
  <script src="renderer.js"></script>
- </body>
 </body>
 </html>

docs/tutorial/dark-mode.md

@@ -75,7 +75,6 @@ Starting with the `index.html` file:
  <button id="reset-to-system">Reset to System Theme</button>
 
  <script src="renderer.js"></script>
- </body>
 </body>
 </html>
 ```

docs/tutorial/esm.md

@@ -78,7 +78,8 @@ JavaScript transpilers (e.g. Babel, TypeScript) have historically supported ES M
 syntax before Node.js supported ESM imports by turning these calls to CommonJS
 `require` calls.
 
-<details><summary>Example: @babel/plugin-transform-modules-commonjs</summary>
+<details>
+<summary>Example: @babel/plugin-transform-modules-commonjs</summary>
 
 The `@babel/plugin-transform-modules-commonjs` plugin will transform
 ESM imports down to `require` calls. The exact syntax will depend on the

docs/tutorial/offscreen-rendering.md

@@ -82,4 +82,5 @@ app.on('window-all-closed', () => {
 
 After launching the Electron application, navigate to your application's
 working folder, where you'll find the rendered image.
+
 [disablehardwareacceleration]: ../api/app.md#appdisablehardwareacceleration