perf: avoid protocol registry redundant lookup #41991
Merged
+53
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
added
performance 🏁
semver/patch
electron-cation
bot
added
new-pr 🌱
codebytere
approved these changes
May 8, 2024
…derFactoryForURL()
refactor: remove unused ProtocolRegistry::IsProtocolIntercepted()
refactor: rename ProtocolRegistry::FindRegistered() similar semantics to base::Value::Find*()
chore: use same variable names as in main
ckerr
force-pushed
the
perf/avoid-protocol-registry-redundant-lookup
branch
from
2edeb5b
to
7acf7b6
Compare
jkleinsc
approved these changes
May 9, 2024
|
No Release Notes |
Mrnikifabio
pushed a commit
to Mrnikifabio/electron
that referenced
this pull request
May 14, 2024
* perf: avoid redundant map lookup in SimpleURLLoaderWrapper::GetURLLoaderFactoryForURL() * perf: avoid redundant map lookup in InspectableWebContents::LoadNetworkResource() * refactor: remove unused ProtocolRegistry::IsProtocolRegistered() refactor: remove unused ProtocolRegistry::IsProtocolIntercepted() * refactor: remove unused ProtocolRegistry::handlers() * refactor: rename ProtocolRegistry::FindIntercepted() refactor: rename ProtocolRegistry::FindRegistered() similar semantics to base::Value::Find*() * chore: follow Google C++ brace style chore: use same variable names as in main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix a performance wart in
ProtocolRegistry. The current workflow is to callProtocolRegistry::handlers().at(scheme)after a safeguard check toProtocolRegistry::IsRegistered(scheme). This workflow requires a redundant lookup forschemeand is also a minor demeter violation.This PR replaces the methods
ProtocolRegistry::IsRegistered(scheme)andProtocolRegistry::handlers(scheme)with a newProtocolRegistry::FindRegistered(scheme) constthat returns a const pointer to the handler, ornullptrif none is found.Checklist
npm testpassesRelease Notes
Notes: none