fix: nativeImage.createThumbnailFromPath
and shell.openExternal
in renderer
#41875
+60
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
nativeImage.createThumbnailFromPath
wasn't resolving when called in therenderer. This started happening in #37701, I think Chromium stopped pumping
the Grand Central Dispatch queue in renderer processes. I haven't figured out
the exact change which caused the regression, but relying on Chromium's own
dispatch queues fixes the issue.
Fixes #41816.
Checklist
npm test
passesRelease Notes
Notes: Fixed nativeImage.createThumbnailFromPath and shell.openExternal not resolving when called in the renderer process.