Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow CI to install older PHPUnit for legacy PHP #43

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

Allow CI to install older PHPUnit for legacy PHP #43

wants to merge 17 commits into from

Conversation

macbre
Copy link
Member

@macbre macbre commented Feb 22, 2023 •
edited

@macbre macbre marked this pull request as draft February 22, 2023 13:07
@macbre
Copy link
Member Author

macbre commented Feb 22, 2023 •
edited

PHP 5.3

PHP Parse error:  syntax error, unexpected '.', expecting '&' or T_VARIABLE in /home/runner/work/amazon-s3-php-class/amazon-s3-php-class/vendor/symfony/deprecation-contracts/function.php on line 23

$ composer why symfony/deprecation-contracts
guzzlehttp/guzzle 7.5.0 requires symfony/deprecation-contracts (^2.2 || ^3.0)

PHP 7.0

PHP Parse error:  syntax error, unexpected '?', expecting variable (T_VARIABLE) in /home/runner/work/amazon-s3-php-class/amazon-s3-php-class/tests/S3Test.php on line 31

@coveralls
Copy link

coveralls commented Feb 22, 2023 •
edited

Pull Request Test Coverage Report for Build 4243895887

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 23.415%
Totals Coverage Status
Change from base Build 4165652942: 0.0%
Covered Lines: 229
Relevant Lines: 978
💛 - Coveralls

macbre
macbre commented Feb 22, 2023
View reviewed changes
composer.lock
@@ -4,7 +4,7 @@
"Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
"This file is @generated automatically"
],
"content-hash": "e6430fd4fd3b675107e7e810bd4cc097",
"content-hash": "29eb968f0fce0432cd3a25efdc815ba1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composer update --lock

@macbre
composer require --update-with-all-dependencies
50cda37
@macbre
Downgrade guzzlehttp/guzzle when forcing an older PHPUnit
c89626c 
Should fix

PHP Parse error:  syntax error, unexpected ':', expecting '{' in /home/runner/work/amazon-s3-php-class/amazon-s3-php-class/vendor/symfony/deprecation-contracts/function.php on line 23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@macbre @coveralls