Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to block Iframes #6

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Support to block Iframes #6

wants to merge 7 commits into from

Conversation

amon-ra
Copy link

@amon-ra amon-ra commented Oct 18, 2018

This changes blocks cookies from iframes using the sandbox option.

@elbywan
Copy link
Owner

elbywan commented Oct 19, 2018

Hi @amon-ra, thanks a lot for your contribution! 👍

Before we can go in depth and review/evaluate the code/features, could you please:

  • provide us with some concrete use case
  • add further explanation about the features you are adding - for instance document the api
  • make unitary pull requests with one single feature (here I can see at least 2 features at first glance: iframe blocking & unblocking by id)
  • make sure that your code contains comments (if needed)

Thanks again, and please let us know when you feel that your PR fullfills these requirements so we can pursue.

@amon-ra
Copy link
Author

amon-ra commented Oct 21, 2018

Sorry for the late response. I have been working, a link, in a big change to support advanced patterns and block other elements apart of scripts.
The syntax used is a string in the form 'element_type:tag/regex/actions'. For example 'iframe:src/blockeddomain/sandbox:allow-scripts'
Needs some more testing but it is in a working state.
Sorry no to fulfills your requirements but this is one big feature, I will try to document in more detail. Thanks for your work.

@vladiiancu
Copy link

Any updates here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants