Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storybook] Add stories for more components (EuiTable components) #7755

Merged
merged 16 commits into from
May 21, 2024

Conversation

mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented May 14, 2024

Summary

closes #7483

This PR adds more stories for EuiTable subcomponents:

  • EuiTableBody
  • EuiTableFooter
  • EuiTableFooterCell
  • EuiTableHeader
  • EuiTableHeaderCell
  • EuiTableHeaderCellCheckbox
  • EuiTableHeaderMobile
  • EuiTablePagination
  • EuiTableSortMobile
  • EuiTableSortMobileItem
  • EuiTableRowCell
  • EuiTableRowCellCheckbox

Additionally adds base VRT reference images based on the added stories.

QA

@mgadewoll mgadewoll added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog labels May 14, 2024
@mgadewoll mgadewoll marked this pull request as ready for review May 14, 2024 15:23
@mgadewoll mgadewoll requested a review from a team as a code owner May 14, 2024 15:23
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Copy link
Member

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delightful!! Thank you again for all your great work Lene, I know this was probably super tedious! 🙇

@mgadewoll mgadewoll merged commit eb8430b into elastic:main May 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New docs] Create stories for EuiTable components
4 participants