Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leak in TransformIndexerFailureHandlingTests #108541

Conversation

DaveCTurner
Copy link
Contributor

Uses ActionListener#respondAndRelease to release the search response
properly. Also cleans up a few other warnings.

Closes #108530

Uses `ActionListener#respondAndRelease` to release the search response
properly. Also cleans up a few other warnings.

Closes elastic#108530
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :ml/Transform Transform v8.15.0 labels May 13, 2024
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label May 13, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks David!

Copy link
Contributor

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner merged commit a46cef4 into elastic:main May 13, 2024
15 checks passed
@DaveCTurner DaveCTurner deleted the 2024/05/13/TransformIndexerFailureHandlingTests-leak branch May 13, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml/Transform Transform Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] GroupByOptimizerTests testOrderByType failing
4 participants