Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IpFilterRemoteAddressFilterTests testThatFilteringWorksByIp #108502

Merged
merged 1 commit into from May 13, 2024

Conversation

albertzaharovits
Copy link
Contributor

@albertzaharovits albertzaharovits commented May 10, 2024

Fixes IpFilterRemoteAddressFilterTests testThatFilteringWorksByIp.
There were 2 "@ Before"-annotated methods that didn't play well together.

Fixes: #108441

@albertzaharovits albertzaharovits added >test Issues or PRs that are addressing/adding tests :Distributed/Network Http and internode communication implementations v7.17.22 labels May 10, 2024
@albertzaharovits albertzaharovits self-assigned this May 10, 2024
@albertzaharovits albertzaharovits marked this pull request as ready for review May 10, 2024 11:02
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team label May 10, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@arteam arteam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albertzaharovits
Copy link
Contributor Author

@elasticsearchmachine test this please

@albertzaharovits albertzaharovits added the auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label May 10, 2024
@elasticsearchmachine elasticsearchmachine merged commit b6dad2b into elastic:7.17 May 13, 2024
9 checks passed
@albertzaharovits albertzaharovits deleted the fix-test-108441 branch May 13, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed/Network Http and internode communication implementations Team:Distributed Meta label for distributed team >test Issues or PRs that are addressing/adding tests v7.17.22
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants