Fix integer overflow in native scalar quantizer #108493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Offsets in memory segments should be computed as longs to avoid integer overflow on large segments.
|
Pinging @elastic/es-search (Team:Search) |
ChrisHegarty
approved these changes
May 10, 2024
ChrisHegarty
added
blocker
test-arm
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci |
|
@elasticmachine run elasticsearch-ci/part-2-arm |
|
@elasticmachine run elasticsearch-ci/part-2-arm |
|
@elasticmachine update branch |
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
May 11, 2024
Offsets in memory segments should be computed as longs to avoid integer overflow on large segments. --------- Co-authored-by: ChrisHegarty <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 12, 2024
Offsets in memory segments should be computed as longs to avoid integer overflow on large segments. --------- Co-authored-by: ChrisHegarty <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent integer overflow on large segments, offsets in memory segments should be computed as longs.
Although I'm not sure about the proper testing for this, I'm opening the fix early to raise awareness.