Strengthen locking in FsBlobContainer register impl
#107830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expands the JVM-wide mutex to prevent all concurrent operations on file-based registers, but then introduces an artificial mechanism for emulating write/write contention within a single JVM.
DaveCTurner
added
>test
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Yep, and I think we can strengthen the repo analysis too |
henningandersen
approved these changes
Apr 24, 2024
| try { | ||
| return doUncontendedCompareAndExchangeRegister(registerPath, expected, updated); | ||
| } finally { | ||
| mutex.close(); |
There was a problem hiding this comment.
Is this not handled by the try-with-resource above?
DaveCTurner
added
the
auto-merge
tlrx
reviewed
May 22, 2024
| if (r.isPresent()) { | ||
| l.onResponse(r); | ||
| } else { | ||
| l.onFailure(new IllegalStateException("register read failed due to contention")); |
There was a problem hiding this comment.
@DaveCTurner raising your attention that it seems to fail AzureSnapshotRepoTestKitIT/testRepositoryAnalysis (see #108504)
There was a problem hiding this comment.
Thanks for the ping, clearly a bug: #108900
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands the JVM-wide mutex to prevent all concurrent operations on
file-based registers, but then introduces an artificial mechanism for
emulating write/write contention within a single JVM.