Skip to content

Commit

Permalink
Treat 404 as empty register in AzureBlobStore (#108900)
Browse files Browse the repository at this point in the history
Closes #108504
  • Loading branch information
DaveCTurner committed May 22, 2024
1 parent 69cc9d6 commit aa542de
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
6 changes: 6 additions & 0 deletions docs/changelog/108900.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
pr: 108900
summary: Treat 404 as empty register in `AzureBlobStore`
area: Snapshot/Restore
type: bug
issues:
- 108504
Original file line number Diff line number Diff line change
Expand Up @@ -828,7 +828,7 @@ OptionalBytesReference getRegister(String blobPath, String containerPath, String
} catch (Exception e) {
if (Throwables.getRootCause(e) instanceof BlobStorageException blobStorageException
&& blobStorageException.getStatusCode() == RestStatus.NOT_FOUND.getStatus()) {
return OptionalBytesReference.MISSING;
return OptionalBytesReference.EMPTY;
}
throw e;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,4 @@ protected Settings repositorySettings() {

return Settings.builder().put("client", "repository_test_kit").put("container", container).put("base_path", basePath).build();
}

@Override
@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/108504")
public void testRepositoryAnalysis() throws Exception {
super.testRepositoryAnalysis();
}
}

0 comments on commit aa542de

Please sign in to comment.