Added support for Kibana Ingress #7839
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naemono
added
>enhancement
naemono
requested changes
May 22, 2024
There was a problem hiding this comment.
Took a quick look and saw a couple of things that initially stood out. Will take a longer look later. Would definitely prefer some test cases added for this ingress functionality specific to different types of ingress, like CSP-specific ingress types, and whether or not this format of values supports all the standard ingress types.
Co-authored-by: Michael Montgomery <[email protected]>
Co-authored-by: Michael Montgomery <[email protected]>
Co-authored-by: Michael Montgomery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for creating an Ingress resource when using the Kibana Helm chart.