Reenable block editing UI tests #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasKalbertodt
requested changes
Mar 18, 2024
owi92
force-pushed
the
adjust-block-test
branch
from
76ebe39
to
a35567f
Compare
LukasKalbertodt
requested changes
Apr 2, 2024
github-actions
bot
added
the
status:conflicts
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
removed
the
status:conflicts
This replaces the `nth()` locator with more specific ones. Using `nth()` is apparently discouraged and indeed lead to some flaky behaviour in the block editing tests. The buttons are now located by using specific unique locators. Blocks containing only text content like title and text blocks can be located by using a regex filter, while the video and series blocks can be located by combining a filter that checks the presence of specific text with a filter that checks for the absence of other specific text (that is contained in another block). However, we do need to make sure that the test steps are performed in a set order: If the text whose presence is checked is removed in a test step, that step needs to be the very last one of that specific block. Otherwise the locator will fail. This also incidentally inlines all the block editing instead of having one large function for it. I do maintain that the function was nicer, but with these new locators it has gotten somewhat pointless.
Since all functions and structures were either moved to more specific files or removed completely, the only thing this file did was reimport/export the test function for convenience. That can now be imported directly in the test files.
LukasKalbertodt
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were previously skipped because they were unreliable and failed often. With the changes from #1093, all tests got a lot more stable, but the old block tests needed adjustments.