Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #7450 sigsegv error when trying to clean up the stacks with missing eks cluster #7731

Closed
wants to merge 1 commit into from

Conversation

veekaly
Copy link
Contributor

@veekaly veekaly commented Apr 26, 2024

Description

This PR is to fix the issue #7450 encountered when using eksctl delete cluster --force command to delete the stacks after manually deleting the eks cluster resource.

When a cluster is inoperable (clusterOperable=false), the c.ctl.Status.ClusterInfo value is nil, and therefore passing c.ctl.Status.ClusterInfo.Cluster to the NewTasksToDeleteClusterWithNodeGroups function (owned.go#L138) is causing the nil pointer exception.

I'm setting the c.ctl.Status.ClusterInfo to an empty struct so that the function signature is respected. The actual value is never used in the function anyway because of clusterOperable=false.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello veekaly 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

@github-actions github-actions bot added the stale label May 27, 2024
@github-actions github-actions bot closed this Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant