Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for wavelength zones #7107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

antevens
Copy link

Allows adding nodegroups with wavelength zones.

Description

Allows the use of wavelengh zones when adding nodegroups.

Fixes

Error: could not find public subnets: could not select subnets from subnet IDs (allSubnets=v1alpha5.AZSubnetMapping{"us-east-1b":v1alpha5.AZSubnetSpec{ID:"subnet-xxxxxxxxxxxxx", AZ:"us-east-1b", CIDR:(*ipnet.IPNet)(0xc000000000, CIDRIndex:0, OutpostARN:""}, "us-east-1f":v1alpha5.AZSubnetSpec{ID:"subnet-x", AZ:"us-east-1f", CIDR:(*ipnet.IPNet)(0x000000000), CIDRIndex:0, OutpostARN:""}} localZones=[]string(nil) subnets=[]string{"subnet-xxxxxxxxxxxxx"}): failed to select subnet subnet-xxxxxxxxxxxxx: error discovering zone types: expected zone type to be local or AZ; got wavelength-zone

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello antevens 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

@antevens
Copy link
Author

Wow aws, good job

@cPu1 cPu1 added priority/important-soon Ideally to be resolved in time for the next release and removed stale labels Oct 31, 2023
@cPu1 cPu1 reopened this Oct 31, 2023
@Himangini Himangini added priority/backlog Not staffed at the moment. Help wanted. and removed priority/important-soon Ideally to be resolved in time for the next release labels Nov 10, 2023
@github-actions github-actions bot added the stale label Dec 11, 2023
@github-actions github-actions bot closed this Dec 17, 2023
@cPu1 cPu1 reopened this Dec 18, 2023
@cPu1 cPu1 removed the stale label Dec 18, 2023
@github-actions github-actions bot added the stale label Jan 18, 2024
@rhbelson
Copy link

Is this a feature that we can revisit (following completion of: #7202)?

@github-actions github-actions bot removed the stale label Jan 23, 2024
Allows adding nodegroups with wavelength zones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-investigation priority/backlog Not staffed at the moment. Help wanted. stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants